Jiawen Geng
Jiawen Geng
We may need to bump nan version ``` npm ERR! /Users/daniel/Library/Caches/node-gyp/18.4.0/include/node/v8config.h:460:35: note: expanded from macro 'V8_DEPRECATED' npm ERR! # define V8_DEPRECATED(message) [[deprecated(message)]] npm ERR! ^ npm ERR! In file included...
@Liamolucko Is there any plan to draft a new release ?
> Hi @gengjiawen, just curious, whats the usecase? Headless chrome? Puppeteer? Mostly frontend e2e testing like cypress and Puppeteer. Recently wasm (wasm-bindgen pretty lame on testing). Another usecase is that...
> I think it would be beneficial to decouple it from there into `tool-chrome` and add `tool-chrome` as a chunk for the `tool-vnc` combination. You mean this part ? I...
ping @axonasif
> Hey @gengjiawen, thanks a lot for your patience, could you please toggle on [`Allow edits from maintainers`](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) on your PR right-side-bar? I want to push some commits into your...
> Thank you for the contribution @gengjiawen! 🎉 > > Could you share a bit more about why you think this should be included? 🙏 I'm concerned that the full...
@axonasif CI passed. Can you merge this ? thx.
> @gengjiawen as also mentioned previously by @kylos101 [[1](https://github.com/gitpod-io/workspace-images/pull/471#discussion_r802202019)], we are not convinced that workspace-full should also contain chrome given it's size. I think it's a balance, and it's worth...
> I understand your point of view. Currently we are very wary of increasing the size of the image and do so only if _really_ needed as it negatively impacts...