Jiawen Geng
Jiawen Geng
Another tricky thing is that we can't even test this on github action due to space limit https://github.com/nodejs/node/pull/35433/checks?check_run_id=1189469828 `LIB : LLVM error : IO failure on output stream: no space...
@targos Can you rebase this, so we can working on new V8 ?
> Regarding the disk space issue: the D:\ drive on Windows VMs [apparently](https://github.com/actions/virtual-environments/issues/1341) has 14GB available - this is also described in the [official docs](https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources). A workaround is to move...
> @nodejs/build-infra Would it be easy to install ClangCL build tools on the Windows machines? Not sure this will help: https://github.com/appveyor/build-images/blob/27bde614bc60d7ef7a8bc46182f4d7582fa11b56/scripts/Windows/install_vs2019.ps1#L192.
Looks like all related to inline function on windows platform.
Now stucks with ``` ..\..\out\Release\obj\v8_libsampler\\deps\v8\src\libsampler\sampler.obj: no such file or directory C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1309,5): error MSB6006: "llvm-lib.exe" exited with code 1. [D:\code\node\tools\v8_gypfiles\v8_libsampler.vcxproj] ..\..\out\Release\obj\v8_zlib\\deps\v8\third_party\zlib\adler32.obj: no such file or directory C:\Program...
> @gengjiawen Does it make any difference if you update to Visual Studio 16.8, which was released yesterday? I forget to remove '/P'. I should try my build now. >...
This is more likely a bug from what I test (refactor the inline implementation). Not sure this need to reported to clang team or msvc team.
> I don't know why, but I'm still unable to create V8 issues. Could someone please do the report for me ([bugs.chromium.org/p/v8/issues/entry?template=Node.js+upstream+bug](https://bugs.chromium.org/p/v8/issues/entry?template=Node.js+upstream+bug))? > > Here's the filled template: > >...
@xc1427 done. @gaearon Can you take another look ?