feat: Node 18 support and drop Node 17

[nschonni]

trafficstars

Fixes #3251 Still needs Node Docker image release before this will pass

[nschonni]

@xzyfer should I just drop the Docker/Alpine part for now so this can just land? It's been flaky for awhile on the previous releases anyway. I picked v8 instead of 7.1, but that can be updated too

[xzyfer]

My hero

[nschonni]

Looks like x86 should be good in 18.3.0 https://github.com/nodejs/build/pull/2956 and Node 17 is EOL tomorrow. @xzyfer would it make sense to push out a release after those 2 things?

[rasmustoender]

@xzyfer would be awesome to have this reviewed soon! :)

[John-H-Smith]

News about that?

[gengjiawen]

@nschonni Can you merge this ? thx

[gengjiawen]

We may need to bump nan version

npm ERR! /Users/daniel/Library/Caches/node-gyp/18.4.0/include/node/v8config.h:460:35: note: expanded from macro 'V8_DEPRECATED'
npm ERR! # define V8_DEPRECATED(message) [[deprecated(message)]]
npm ERR!                                   ^
npm ERR! In file included from ../src/binding.cpp:1:
npm ERR! In file included from ../../nan/nan.h:2818:
npm ERR! ../../nan/nan_typedarray_contents.h:34:43: error: no member named 'GetContents' in 'v8::ArrayBuffer'
npm ERR!       data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;

[reynldi]

Any update ? For how long we need to wait this PR ?

[eduardocque]

+1

[alexgwolff]

Hi, any update?

[eduardocque]

Hi, any updates about this @nschonni

Regards

[chrishough]

+1

[hanorine]

Would love to see this merged in too. Hoping this package is still maintained. +1

[eduardocque]

finally

[nholden-re]

Now that Node 18 is the active LTS, can we please get this PR some traction?

[wratho]

Really would like to hear an update on the state of Node 18. currently blocked from progressing without it.

[Shane32]

If not a final release, could a beta release be published with node 18 support?

[reynldi]

Master should be fixed now and nan and node-gyp have been updated to support node 19.

Awesome !

[doncem]

well that took just a brief period of time :smirk:

[xzyfer]

That's on me. Apologies to everyone waiting on this release, and to @nschonni for disappearing for a little while.

Part of our release process for when adding new Node versions I still run manually offline and I was occupied with other priorities. We're looking to better automate the process for future releases.