Edy Silva comments

Results 91 comments of


                                            Edy Silva

module: fix error reporting

> @RafaelGSS are you still blocking? he wanted to check if all tests would pass before. Tests were failing on windows though. A friend of mine helped me out and...

test_runner: ignore unmappes lines for coverage

> Can you add a test? > > Without a test, it's unclear what this change accomplished / fixed I'm not sure which tests to add. Do you have any...

test_runner: ignore unmappes lines for coverage

> IMHO I'm not sure how I feel about this change. It breaks the existing tests (as they required modification), and IIUC those tests are valid before this change. >...

test_runner: ignore unmappes lines for coverage

> This may fix that issue, however I'm concerned that it breaks existing tests. I see If this PR reaches the expected behavior, should we update those tests then? If...

test_runner: ignore unmappes lines for coverage

Closing this in favor of #55228

AbortSignal.any() causes memory leak

I started taking some snapshot @RedYetiDev would you have any clue?

util: update util.isArray() to eol

I think build is failing because a link to the `util.isArray` still exists at https://github.com/nodejs/node/blob/main/doc/api/deprecations.md?plain=1#L998 and https://github.com/nodejs/node/blob/main/doc/api/deprecations.md?plain=1#L4031.

`Copy to clipboard` button does not work

Hey guys. I just tested it. Now it works.

assert: fix deepStrictEqual on errors when cause is present

I tried to follow your suggestion @BridgeAR but doing that after inspection would turn `expect` and `actual` into strings which would make the process of removing stack frames, at least...

assert: fix deepStrictEqual on errors when cause is present

I can do that, folks. EDIT: By the tags, it looks like @aduh95 backported it.