node icon indicating copy to clipboard operation
node copied to clipboard

util: update util.isArray() to eol

Open miguelmarcondesf opened this issue 7 months ago β€’ 11 comments

Refs #58013

Update util.isArray to eol

miguelmarcondesf avatar Apr 25 '25 18:04 miguelmarcondesf

It seems like there is still some hesitation about doing this - https://github.com/nodejs/node/issues/58013#issuecomment-2830512399.

cjihrig avatar Apr 25 '25 19:04 cjihrig

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 88.45%. Comparing base (24ded11) to head (98d5b07). :warning: Report is 576 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58027      +/-   ##
==========================================
- Coverage   88.45%   88.45%   -0.01%     
==========================================
  Files         703      703              
  Lines      207544   207541       -3     
  Branches    40013    40010       -3     
==========================================
- Hits       183587   183580       -7     
+ Misses      15965    15950      -15     
- Partials     7992     8011      +19     
Files with missing lines Coverage Ξ”
lib/util.js 97.95% <ΓΈ> (-0.02%) :arrow_down:

... and 37 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 25 '25 20:04 codecov[bot]

I think build is failing because a link to the util.isArray still exists at https://github.com/nodejs/node/blob/main/doc/api/deprecations.md?plain=1#L998 and https://github.com/nodejs/node/blob/main/doc/api/deprecations.md?plain=1#L4031.

geeksilva97 avatar Apr 26 '25 01:04 geeksilva97

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - util: update util.isArray() to eol
   ⚠  - Update version change with pr number
   ⚠  - fix endoflife typo
   ⚠  - Fix typo from version
   ⚠  - doc: update deprecation notice for util.isArray() removal
   ⚠  - doc: remove unused reference to Array.isArray() in util documentation
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/14686825918

github-actions[bot] avatar Apr 27 '25 01:04 github-actions[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66500/

nodejs-github-bot avatar Apr 28 '25 13:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66515/

nodejs-github-bot avatar Apr 30 '25 14:04 nodejs-github-bot

CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3587/

marco-ippolito avatar Apr 30 '25 14:04 marco-ippolito

+1 Moving this EOL to Node.js 26.

@RafaelGSS Cool, I'll fix the conflicts today

miguelmarcondesf avatar Sep 23 '25 12:09 miguelmarcondesf

CI: https://ci.nodejs.org/job/node-test-pull-request/69337/

nodejs-github-bot avatar Sep 23 '25 13:09 nodejs-github-bot

Let's land it only when v25 goes out. Due to the upcoming V8 update, I might need to sync main with v25.x.

RafaelGSS avatar Sep 23 '25 14:09 RafaelGSS

Bump this can be updated and merged ? FYI userland migrations had furnished a codemod for this dep

AugustinMauroy avatar Nov 22 '25 12:11 AugustinMauroy