util: update util.isArray() to eol
It seems like there is still some hesitation about doing this - https://github.com/nodejs/node/issues/58013#issuecomment-2830512399.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 88.45%. Comparing base (24ded11) to head (98d5b07).
:warning: Report is 576 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #58027 +/- ##
==========================================
- Coverage 88.45% 88.45% -0.01%
==========================================
Files 703 703
Lines 207544 207541 -3
Branches 40013 40010 -3
==========================================
- Hits 183587 183580 -7
+ Misses 15965 15950 -15
- Partials 7992 8011 +19
| Files with missing lines | Coverage Ξ | |
|---|---|---|
| lib/util.js | 97.95% <ΓΈ> (-0.02%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
I think build is failing because a link to the util.isArray still exists at https://github.com/nodejs/node/blob/main/doc/api/deprecations.md?plain=1#L998 and https://github.com/nodejs/node/blob/main/doc/api/deprecations.md?plain=1#L4031.
Failed to start CI
β Commits were pushed since the last approving review: β - util: update util.isArray() to eol β - Update version change with pr number β - fix endoflife typo β - Fix typo from version β - doc: update deprecation notice for util.isArray() removal β - doc: remove unused reference to Array.isArray() in util documentation β Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14686825918
CI: https://ci.nodejs.org/job/node-test-pull-request/66500/
CI: https://ci.nodejs.org/job/node-test-pull-request/66515/
CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3587/
+1 Moving this EOL to Node.js 26.
@RafaelGSS Cool, I'll fix the conflicts today
CI: https://ci.nodejs.org/job/node-test-pull-request/69337/
Let's land it only when v25 goes out. Due to the upcoming V8 update, I might need to sync main with v25.x.
Bump this can be updated and merged ? FYI userland migrations had furnished a codemod for this dep