Edy Silva
Edy Silva
> > > ... sorry but what do you mean by "flagged feature in V8"? > > > > > > The `Error.isError` API, while enabled by default now in...
> Not blocking, but looks like this fixed the repro reported by the OP, but not the one mentioned at [#55328 (comment)](https://github.com/nodejs/node/issues/55328#issuecomment-2405331248) Oh, that's the code I used to reproduce...
> The added test seems very flaky. For example https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/47103/testReport/junit/(root)/parallel/test_abortsignal_drop_settled_signals/ It is actually. https://github.com/nodejs/node/issues/56190 Should we revert instead of fixing it?
Weirdly, the changes impacted a test that was working before.
> You're right. In this example the failure is in `drops settled dependant signals when signal is composite`. We should probably revert if we don't find a fix quickly How...
> > You're right. In this example the failure is in `drops settled dependant signals when signal is composite`. We should probably revert if we don't find a fix quickly...
I think I found it, @targos. I will open a PR in a sec.
> Thanks for opening a PR! Can you please add a unit test? Sure! It's done 🫡
> > The PR changes this behavior by making the error reporting to get the last frame on the stack since it will be where all calls were triggered from....
> > Wrong assumption from my side. Thanks for pointing that out. I just pushed a fix. > > It takes the first frame after TraseSync. I will also get...