K. S. Ernest (iFire) Lee

Results 1345 comments of K. S. Ernest (iFire) Lee
trafficstars

See also ~~https://github.com/nikitalita/lldb-qt-formatters~~ from @nikitalita https://github.com/nikitalita/lldb-qt-formatters/blob/godot/GodotFormatters.py

I would prefer a Godot Engine integration because this is not a trivial script to write for lldb support.

A common way that c++ handles this is by api interface inheritance. 1. you provide an interface that either has no implementation or return the inputs 2. for each implementation...

Not that familiar with manifold but where is the c++ method prototype that is common?

What is the benefit for this code style change? Edited: it's not very long so it's probably ok and localized to gdscript

Do you have a test case project for reviewing?

@Calinou How do I queue this to run on the benchmark servers? Also can you take a look?

@lexaknyazev Can you reply and remove the block or at least state reasoning for keeping the block?

@TokageItLab I think this is ok, but I may have missed a conceptual problem. Can you review?

As someone who touched the older areas of the compression I think this is a good idea, but we probably want to merge code changing the 3d compression types earlier...