Maciej Holyszko comments

Results 56 comments of


                                            Maciej Holyszko

Add automatic dark mode for services through darkreader

https://github.com/ramboxapp/community-edition/pull/2823 could this be ported over, after it finds its way to the rambox repo? @TheGoddessInari

fix: restore serialization of DateTime scalar to pre-1.2.0 (values must be serialized to string, not to instance of Date) + clarify that timestamps are ECMAScript (milliseconds), not unix timestamps (seconds)

I initially restored handling of Unix timestamps in [#48402fe](https://github.com/Urigo/graphql-scalars/pull/1641/commits/48402fe6395276fa1e5c50306abc63bb8b6f2f29) , as it was expected with `graphql-iso-date` and still as described in docs of `graphql-scalars` https://www.graphql-scalars.dev/docs/scalars/date-time but then I noticed it...

Add `SetNonNullable` type

looking forward to this to be included 👍

possibility to search test (with diacritics) as starts with

+1 !

fs.readFile reads wrong file after renaming parent dir

@streamich try this reproduction, please: 🙏 ```javascript const fs = require('memfs'); fs.mkdirSync('dir', { recursive: true }); fs.writeFileSync('dir/file.ext', 'asdf'); fs.renameSync('dir', 'newdir'); fs.readFileSync('newdir/file.ext', 'utf8'); ``` Still tries to read from the old...

fs.readFile reads wrong file after renaming parent dir

Also note: `statSync('newdir/file.ext')`, `accessSync`, `existsSync` all work fine after rename! But `vol.toJSON()` still lists the file under the "old" path: `{ '/(...)/dir/file.ext': 'asdf' }`

Auto-closing streams throw EBADF errors when the volume is cleared in the meantime

Thanks for all the suggestions, > Could you await until the request completes in your test? So when `vol.reset()` is called the file is already closed. I think I am...

feat(chunk): support for chunked snapshots

I'd love to see this merged 👍

[Serializer] Allow to provide a "normalizer" callable to normalize a property during denormalization

Yes.

[Serializer] Allow to provide a "normalizer" callable to normalize a property during denormalization

I believe it's been covered by https://github.com/symfony/symfony/pull/39399 ?