Maciej Holyszko

Results 58 comments of Maciej Holyszko

@koskimas I've added some tests and adjusted docs.

@kibertoad would you mind to take a look at this PR and review it while you are at it, please? It's the oldest among currently open PRs. Hopefully it has...

@lehni @umutuzgur I've just run our test suites with the changes from https://github.com/Vincit/objection.js/pull/2452 applied and nothing broke.

https://github.com/Urigo/graphql-scalars/pull/1641

> @kibertoad any documentation for it? I didn't see it in the merged PR... I think this PR addresses it https://github.com/knex/documentation/pull/414

@Vincent1q I don't want to spoil it for you, but switch oled has equally bad PWM 🙈 both steam deck and switch use the same series of samsung oled screens......

I've added a typings test for join.onIn + subquery case, but then I realized objection's typings currently do not allow that, because `Knex.JoinClause` is referenced directly https://github.com/Vincit/objection.js/blob/23b8ac112ff095b5d6d8ac2f60b9af87d9028a77/typings/objection/index.d.ts#L611 and that, in...

They fail because of typing errors coming from `tsc`, ``` Error: tests/ts/query-builder-api/join-methods.ts(64,29): error TS2345: Argument of type 'QueryBuilder' is not assignable to parameter of type 'readonly any[] | Raw'. Type...

Related: https://github.com/actions/runner/issues/514

All the `swc` would need to do in case of a decorated class, is to copycat the `tsc` behavior, which itself slaps a workaround on to mitigate the issue. so...