Sebastian "Sebbie" Silbermann

Results 704 comments of Sebastian "Sebbie" Silbermann

Tracking this in https://github.com/facebook/react/issues/29915 as well. `StrictMode` went through a refactor in React 19 so it's not unlikely something broke considering Next.js has the same issue.

react-three-fiber also had to update its reconciler implementation. One of the breaking changes that was hard to track down was around [`commitUpdate`](https://github.com/facebook/react/blob/main/packages/react-reconciler/README.md#commitupdateinstance-type-prevprops-nextprops-internalhandle) which is no longer called with an `updatePayload`....

I don't see what else we can do. This is just inherent to breaking changes in a library. > What is the suggested path here @eps1lon ? The suggested path...

What are the next steps to get this merged? This is affecting sourcemaps in bundlers like Webpack and Turbopack that use `vm.runInThisContext` instead of `(0, eval)`.

Should this have affected `vm.runInContext`? I can't get `vm.runInContext` to sourcemap stack traces when I use Node.js built from this branch. Full repro: https://github.com/eps1lon/vm-sourcemaps. Though tests seem to indicate otherwise....

Thanks for the feedback. Frozen repro with v5: https://codesandbox.io/s/basicaccordion-material-demo-forked-l3u0y?file=/demo.tsx We could fix this by adding `style={{overflow:'hidden'}}` to the parent `Accordion` or applying the same border-radius to the `AccordionDetails` and `AccordionSummary`....

This element is typed for 7 years now and works on minimal apps: ```tsx ``` [Playground Link](https://www.typescriptlang.org/play/?#code/DwEwlghgNg9g5gAhgBwKYDsEHoB8Q) There's likely something else wrong. Does the same error occur when you just...

> even if user had appendComponentStack setting enabled, all emitted error and warning logs are not going to have component stacks appended This is still the case with this change?...

I think this makes sense to list the implicit context here. It's not that much more verbose. There are other messages that also just say "to Client Components" that we...