Sebastian "Sebbie" Silbermann comments

Results 697 comments of


                                            Sebastian "Sebbie" Silbermann

[@types/react]: allow useState setter void calls when undefined

> Should I update that one in this PR or how those cases are handled? Yes. `$ExpectType` is usually safe as long as it structurally matches.

[react] Explicitly allow async Form Actions

Ready to merge

[react] Explicitly allow async Form Actions

`void` is to signal that the return type is ignored. If you're sure that you both want to return a value but ignore it in certain positions, you should ignore...

[react] improve act() return value

Then we can't merge this.

[react] improve act() return value

It's likely that `act` will become fully async anyway and then we don't have to be sophisticated with the types.

[@types/react]: improve useState type-check usage with functions

Is the allowing void coupled with the type-checking functions as state? If not, we need to land it separately to make it clear in the future what change in types...

[@types/react]: improve useState type-check usage with functions

While you're still working on this, could you mark this PR as a draft so that maintainers don't get pinged again?

[react] Make all refs mutable by default

> I also think if we are making breaking changes for React 19, we should not allow the zero argument version of useRef() since there are no documented uses in...

[react] Make all refs mutable by default

> If I understand correctly, divRef will be mutable in React 19. Should we keep it as such even though it's not supposed to be mutated? There was never such...

[react] Make all refs mutable by default

> A restriction about not mutating it? At the type level, yes. But types are in service to how we want React code to be authored. And there this restriction...