react
react copied to clipboard
Fix:- fixed error message of event handler message
The error message of Event handlers cannot be passed to Client Component props. seems a bit confusing as we are talking in the context of passing the same from Server components, so we should brief this error message by adding
Event handlers cannot be passed to Client Component props from Server Component
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-compiler-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 9, 2024 3:08pm |
Comparing: 984ea11d147b1bc7a5e63f576af47629937c58ee...8eabfbba321272839be7a3cc5e27ebd0113ae971
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.js | = | 6.68 kB | 6.68 kB | = | 1.82 kB | 1.82 kB |
| oss-stable/react-dom/cjs/react-dom-client.production.js | = | 505.22 kB | 505.22 kB | = | 90.29 kB | 90.29 kB |
| oss-experimental/react-dom/cjs/react-dom.production.js | = | 6.69 kB | 6.69 kB | = | 1.83 kB | 1.83 kB |
| oss-experimental/react-dom/cjs/react-dom-client.production.js | = | 512.41 kB | 512.41 kB | = | 91.50 kB | 91.50 kB |
| facebook-www/ReactDOM-prod.classic.js | = | 600.74 kB | 600.74 kB | = | 106.27 kB | 106.27 kB |
| facebook-www/ReactDOM-prod.modern.js | = | 577.03 kB | 577.03 kB | = | 102.41 kB | 102.41 kB |
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)
Generated by :no_entry_sign: dangerJS against 8de1389ca7c18b879baa1c723a26080ea4339e78
hmm.. test from react markup breaking up, need to align those test as well!
not sure how to fix the markup tests! i tried running the same command in local, but it is not showing the same test fail stabs!
LGTM
Please don't spam on PR,s, i have seen you spamming all over PR without any reasonable replies!
LGTM
Please don't spam on PR,s, i have seen you spamming all over PR without any reasonable replies!
First try to understand what 'LGTM' means
LGTM
Please don't spam on PR,s, i have seen you spamming all over PR without any reasonable replies!
First try to understand what 'LGTM' means
what do you know about this PR? what makes you feel this is good to you?
cc @sebmarkbage @eps1lon would love to know your review on this!
@sebmarkbage what do you think?
I think this makes sense to list the implicit context here. It's not that much more verbose. There are other messages that also just say "to Client Components" that we should adjust.
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!