Bryan Elliott

Results 12 comments of Bryan Elliott

I am currently working on task: [Add messaging for missing plugins that are needed for purchased products to work](https://github.com/Automattic/jetpack-roadmap/issues/1393), which is related to this issue and will resolve this issue....

This was fixed in: https://github.com/Automattic/jetpack/pull/41013

> I am Adding Martech as a reviewer to double-check that I am changing the right files and covering everything needed for the initial setup. Hmm, I tried functional testing...

This issue is currently being worked on and resolved in PR https://github.com/Automattic/wp-calypso/pull/94831 (in progress)

> For the testing plan: we can also modify plugin files in WP Admin directly (`/wp-admin/plugin-editor.php`) Oh nice! I forgot about that! Ok, thanks! 👍 > I think we can...

> Also, thank you @elliottprogrammer for clarifying the instructions regarding testing. I do get 1 treat now on the free version. However, I do have a question. When I upgrade,...

> Code looks a lot better thanks! > > Lovely that you collaborated with @CodeyGuyDylan on translation strings - the final idea is really neat! > > I've left a...

Thanks for the excellent review @CodeyGuyDylan, I've addressed all feedback. 🙌

> Thank you for all of the changes! It works much better for me. I did have some more comments but not nearly as many as last time 🤔 I...

First, thanks very much for the reviews @CodeyGuyDylan! 😃 Oh, my apologies Dylan, I meant to address/answer these points/feedback from your first review. > I mentioned this is the [other...