David Snopek

Results 604 comments of David Snopek

> Can you elaborate on `the bug that the engine class registrations were added to fix` or link to the issue here so I can take a look. PR https://github.com/godotengine/godot-cpp/pull/1050...

I'm going to close this for now. While reducing build size is certainly a worthy goal, the approach explored in this PR isn't the right one. A new PR can...

> Question is if we should add the `.uid` file? Hm. If uid's are supposed to be unique, then I guess we shouldn't add the `.uid` files? Otherwise everyone who...

> I think it's fine as long as they're unique within one project. I don't see a reason to have them be unique outside of it. Though perhaps I'm missing...

It's true that because we're using the `4.4` branch of godot-cpp, the resulting GDExtension would only load on Godot 4.4+ (and give an error message about it on earlier versions)...

> I also thought this was the only safeguard. What's the reason for having this twice? The `minimum_compatibility` is checked by Godot, and it's done before ever trying to load...

Thanks! I have personally made C++ classes that have properties that are enumerations and never experienced this issue. Could you share an MRP or some of your code?

Just given the timeline, this could be related to PR https://github.com/godotengine/godot/pull/99551 which was merged between 4.5-dev1 and dev2, and affects the VRS code

> I think the solution to this issue is rather simple: `.gdextension` authors should publish _consistent_ binaries that are used both in the editor, as well as game releases. It...

> Oh, that's good! Then i suppose all that this proposal really needs is two PRs to change the default (godot-cpp-template) and recommended (docs) ways of doing this. If we...