David Snopek comments

Results 604 comments of


                                            David Snopek

[Core] Improve `CowData` and `Memory` metadata alignment.

Thanks! Is there a reason this is still a draft? Since the Godot PR is merged, it'd be great to get this one merged as well

[Core] Improve `CowData` and `Memory` metadata alignment.

Thanks!

[Core] Improve `CowData` and `Memory` metadata alignment.

Cherry-picked for 4.2 in PR https://github.com/godotengine/godot-cpp/pull/1410

[Core] Improve `CowData` and `Memory` metadata alignment.

Cherry-picked for 4.1 in PR https://github.com/godotengine/godot-cpp/pull/1411

[DRAFT] Avoid creating objects that Godot is going to use placement new to initialize (mark 2)

Ack, I made a really dumb mistake (fixed in my last push)! Sorry for wasting your effort on testing that. I'll do some testing of my own with your test...

[DRAFT] Avoid creating objects that Godot is going to use placement new to initialize (mark 2)

@allenwp I just tested with the code you shared above, and in my latest version I'm not seeing the corruption or the memory leak! When I have a chance, I'm...

[DRAFT] Avoid creating objects that Godot is going to use placement new to initialize (mark 2)

@cyberpuffin-digital Thanks for the review and testing! I've updated this PR to cover most variant types: definitely all the ones that use reference counting and could leak, plus a couple...

[DRAFT] Avoid creating objects that Godot is going to use placement new to initialize (mark 2)

> Maybe add a comment describing this? Makes sense! I've added a `@todo` comment in the conversion methods where we could consider avoiding the extra initialization in the future.

[DRAFT] Avoid creating objects that Godot is going to use placement new to initialize (mark 2)

Yep, those ones should stay the way they are, because they are already not initializing their values.

[DRAFT] Avoid creating objects that Godot is going to use placement new to initialize (mark 2)

Thanks!