David Snopek

Results 604 comments of David Snopek

Thanks! I haven't tested this, but looking at the code, it appears that `UtilityFunctions::weakref()` can be used to make a `WeakRef`. Does that work for you?

If you've updated to godot & godot-cpp master, you may also need to replace the extension_api.json in godot-cpp by running this command with the godot version you are using with:...

The example SConstruct in the docs _should_ work. I used it a couple months ago in a live GDExtension demo where it worked, and looking at the code now, it...

Thanks! At a high-level, this seems good. And the test you added passed. However, I'm personally only really involved in GDExtension, not GDNative, so I don't feel comfortable approving this....

Thanks, Fabio! This is looking awesome so far :-) It'd be great if ancestors of the enabled classes were automatically included, so you can just specify the `WebRTC*` classes, and...

> And I had to edit godot.cpp to prevent it from including `editor_plugin.hpp` Ah, we probably need a special case to set a `#define` to remove the editor plugin stuff...

@Faless What else do you want to add before taking this PR out of draft? I just tested it again after rebasing on `master`, and aside from needing to add...

Exposing `is_playback_active()` and `is_playback_paused()` will need to start with a change to Godot itself to make them available to GDExtension. I'm not familiar at all with the audio subsystem in...

> @dsnopek When you say "...assuming that it'd be safe...", what would be the safety criteria to look out for in terms of GDScript and C#? This is a question...

Thanks, this is an interesting feature! However, one of the design goals of godot-cpp is to provide (as much as possible) the same API as used internally by Godot modules....