Douglas Wilson

Results 1985 comments of Douglas Wilson

PRs to implement are welcome and will speed up the time-to-release significantly :)!

Hi @tomcon, you're welcome to work on a pull request to implement this feature! We would love it!

Hi @Stavanger75, you're welcome to work on a pull request to implement this feature! We would love it!

Indeed, @ifsnow submitted it a few days after my invite :)

Thanks! Unfortunately I'm not comfortable pulling this in due to breaking people's code. For example, I have seen SO answers using the "queryFormat" to alter the SQL (rather than purely...

What if the guard was just directly added within the SqlString.format? Does that still have the same speedup? It would mean that the speed up extends to anyone using our...

Gotcha. I'm afraid for people who have overwritten SqlString.format , which is possible, they would break, and I'm just not confortable breaking them. I can hold this for when 3.0...

By the way, if you have other changes, see if you can PR them this weekend if you would like to see them land in 2.11.0. I need to fix...

Hi @mikesamuel makes sense. Yes, ideally if this can work on all Node.js versions, that would be best, because we strive to support as many Node.js versions as possible since...