Douglas Wilson
Douglas Wilson
> The issue with the test was that, the tested template did not contain the {style} token anymore. That's OK, but people need to be able to use a custom...
> Therefore testing if they are inline will fail. However they are part of the new "?css/text" request. Can you make the test check the correct place instead, then? That...
> please let me know if the test meets your expectations Yes, they looks fine now. My only other main problem is it still isn't backwards-compatible :( because `exports.html` does...
You don't have to change any of those things if you don't want, but I just cannot merge it right away without the backward-compatibility kept.
Another issue is that the documentation says that if you provide your custom template, you place a `{style}` that will get replaced with the default styles, but the changes also...
If you like, I can add tests for all these features to the test suite (no one says our test suite isn't lacking) and you can rebase your changes on...
> Okay cool lets do that OK :) I'll let you know when I added them based tests I would like to see continue to work :) Should be sometime...
@jantimon sorry for the delay; I found a couple bugs while adding tests, etc. So right now there should be most tests to help you with backwards-compatibility if you are...
> Do you need any help integrating the code? I think we are at a good point right now :) The only thing more I can think of is if...
Hi! The point of the rendering is to be independent of any interaction and creating side-effects from the request, thus why we do not provide the `req` and `res`. Can...