David Grudl comments

Results 448 comments of


                                            David Grudl

Generalized Route::getTargetPresenter()

I think that `getTargetPresenters` can be part of IRouter.

Generalized Route::getTargetPresenter()

I would prefer to avoid BC break. This method can be in interface in v2.3 commented out and checked via method_exists.

Generalized Route::getTargetPresenter()

Typo in commit message: IRouter

Generalized Route::getTargetPresenter()

Yes, will you finish it?

Generalized Route::getTargetPresenter()

ping @JanTvrdik

Security: allow removing characters above U+FFFF in RequestFactory

utf8mb4 enabled, thx for suggestion https://github.com/nette/database/commit/79886631edf37c27f079814bd2de417cb577c7fe

Security: allow removing characters above U+FFFF in RequestFactory

| | strict | nonstrict | note | | --- | --- | --- | --- | | names utf8, table utf8 | error 1366 | truncates string | for...

Selection::getPreviousAccessedColumns must return array or null [Closes #160]

What about change `FALSE` to `NULL` via `return array_keys(array_filter((array) $this->previousAccessedColumns)) ?: NULL`? It will be consistent with other similar changes in framework.

Cache should log all actions to Tracy

this is related 6a7b96ddcc765572aea6e50685f18b51ca006634

Http\RequestFactory: added workaround for exceeded post_max_size

Tohle je věc, kterou bych ve frameworku rád vyřešil. A ano, důležité je, aby uživatel byl srozumitelně informován o tom, že soubor je moc velký. Nicméně parsování inputu na straně...