database icon indicating copy to clipboard operation
database copied to clipboard

Selection::getPreviousAccessedColumns must return array or null [Closes #160]

Open hranicka opened this issue 8 years ago • 3 comments

  • bug fix? yes
  • new feature? no
  • BC break? no

Just fixed annotation + array return typehint for Selection::getPreviousAccessedColumns.

Fixes #160

hranicka avatar Feb 02 '17 10:02 hranicka

What about change FALSE to NULL via return array_keys(array_filter((array) $this->previousAccessedColumns)) ?: NULL? It will be consistent with other similar changes in framework.

dg avatar Feb 02 '17 12:02 dg

@dg Right, it's fine. I've changed it, master :-)

hranicka avatar Feb 02 '17 12:02 hranicka

Now, tests are failing. Previous changes (return an empty array instead of FALSE) were OK: https://travis-ci.org/nette/database/builds/197590334

hranicka avatar Feb 02 '17 15:02 hranicka