David Grudl

Results 462 comments of David Grudl

Can you explain it any further, I don't understand.

fixed, constant type can be nullable 03acaa6bb5016e4ea9ed205b1bec96a432458f14 and PsrPrinter is not final c511194b601d1daf57626d28b1f4538aabc2e8d9 I need to consider protected methods carefully; they can complicate further development.

Wouldn't it be better to set `setAutoRefresh(false)` in this case ?

This is, of course, an unintended BC break. Couldn't you fix your CustomControl?

Of course duplicate the code, there's nothing wrong with that. It avoids a lot of problems.

Yes. I understand that it broke your code, but using inheritance was wrong in this case, it violated LSP. So the correct solution is to get rid of inheritance and...

What exactly is the problem with this?

What do you mean exactly by "make an official tree sitter grammar"? I understand that there is a grammar from daun and from you, but I don't know which one...

I don't have Blackfire. Could you check where those allocations occur?