Daco Harkes

Results 402 comments of Daco Harkes
trafficstars

Note from discussion with @mkustermann * Privacy manifests belong to a `NativeCodeAsset`s. So that leans towards option 1. This not only important for embedders consuming assets, but also for if...

`dart_build` still doesn't cover a link hook. I think I'd prefer `build_hook` over `dart_build`, it's more clearly connected the "hook"s (https://github.com/dart-lang/sdk/issues/54334). What's a good name for the "build hook" and...

Notes from discussion with @mosuem * `package:build_hook/build.dart` * `package:build_hook/link.dart` contains `LinkConfig` and `LinkOutput` (`package:compilation_hooks/build.dart` was rejected because compilation_hooks is hard to connect with build.dart and link.dart)

From discussion with @mkustermann @HosseinYousefi @mosuem: * `package:hook/build.dart` and `package:hook/link.dart`. Which might conflict with `package:hooks` (11 years old, not update in 10 years). Maybe that package can be deprecated.

> I sent the invite to [[email protected]](mailto:[email protected]) Thanks @influx6! I have accepted the invite. 👍 @jonasfj Is marking the `package:hooks` discontinued enough for us to be able to upload a...

@influx6 You might want to update the readme on the repo that it's discontinued and archive the GitHub repo. Given that the SDK constraint is `

If we're going for `package:hook` (singular), then it's slightly weird to go for `package:code_assets` (plural) and `package:data_assets` (plural). Because we will start name spacing with package name (https://github.com/dart-lang/native/issues/2132), we need...

The majority of packages related to icon, font, asset have plural names on pub.dev, so I'm leaning towards plural for `data_assets` and `code_assets`. For the `hook/` directory we've settled in...

And a Flutter tracking issue for the template: * https://github.com/flutter/flutter/issues/151646

> To fix this we'll need to adjust the types of any method args that conflict like this so that the subtype's method args are as general as the supertype's....