Daco Harkes

Results 416 comments of Daco Harkes
trafficstars

That is true, the C code could return rogue values, if we want to support exhaustiveness checking, we should check the int value at the moment we get the value...

> I modeled CanStatus.example to have the value 1 and still be distinct from Canstatus.ok. If they should be identical then we can do this: > > ```dart > enum...

Sorry for the ambiguity! 🤓 > I'm not sure I understand, I suppose that wouldn't mean `assert(CanStatus.ok.toString() == 'CanStatus.ok, CanStatus.example')`? No, that is exactly what I want. It has two...

Package rename is tracked in: * https://github.com/dart-lang/native/issues/999

Data assets are part of the protocol now, and the protocol is extensible. They have not been implemented in Dart and Flutter yet, but that's tracked by separate issues.

Also, when doing another approval on the same commit range, it shows the message of the previous approval.

> If a flaky test resumes the failure mode it had before flaking, it should not be reported as a new failure. > Does this cover the cases you mention...

@mit-mit Do you happen to know if we need to enable it? And, do you happen to know who might know the answer to coverage with a mono-repo? `package:jnigen` has...

> Possibly something you can configure from the coveralls.io UI? https://coveralls.io/better-monorepo-support I have no configuring powers on coveralls.io for this GitHub repo.

Possible fix: make `pub get` apply to all subfolders: https://github.com/dart-lang/pub/issues/3855