Daco Harkes

Results 416 comments of Daco Harkes
trafficstars

@liamappelbe mentioned that we'd need to deal with renames and super classes, so probably we should generate something along the lines of: ```dart @ResourceIdentifier({ 'jnigen': true, 'java_class' : 'SomeClass', 'java_method'...

> What does the `@ResourceIdentifier` annotation look like? Due to renaming It would be very brittle to try to infer the ObjC names for the classes and methods based on...

One slight issue is that the `assetId` might not entirely be obvious when generating. So maybe `assetId` should be optional. Something along the lines of: ```yaml # ffigen.yaml native: assetId:...

> Alternatively, we can make FFIgen generate the resource identifier annotations. We settled on this, and it's already tracked in other issues.

`dart pub global run coverage:test_with_coverage` is run for both package:jni and package:jnigen separately. I don't know if package:coverage has any support for running for mono_repos. packages `package:native_*` have the same...

Thanks for diving into this @liamappelbe!

Notes from discussion with @mkustermann: Maybe we should not 1. conflate user-defines and tree-shaking "inverse meta data", and 2. run builds _after_ kernel compilation. Instead, we should consider 1. having...

Having a build phase and tree-shake phase does raise the question what the CLI interface should be for the tree-shake phase. * Should both the build phase and tree-shake phase...

> What does `in reverse order` mean? Dependencies get the "meta data" / "config" from the dependants. E.g. `package:foo` depends on `package:messages`, so the config from `package:foo` `data/messages.json` flows to...