tools icon indicating copy to clipboard operation
tools copied to clipboard

[cli_config] Fix coverage setup

Open dcharkes opened this issue 2 years ago • 3 comments
trafficstars

The simple coverage setup from https://github.com/dart-lang/tools/pull/42 seems to not show up on https://coveralls.io/github/dart-lang/tools.

Either it's misconfigured, or we need to approve it somewhere.

Also, we need to configure it that it's for a sub-package here. As this is a mono-repo with multiple packages.

dcharkes avatar Mar 23 '23 21:03 dcharkes

@mit-mit Do you happen to know if we need to enable it?

And, do you happen to know who might know the answer to coverage with a mono-repo?

package:jnigen has two sub-packages, but they upload coverage in one workflow: https://github.com/dart-lang/jnigen/blob/main/.github/workflows/test-package.yml This mono-repo has a GitHub workflow per package.

dcharkes avatar Mar 23 '23 21:03 dcharkes

Possibly something you can configure from the coveralls.io UI? https://coveralls.io/better-monorepo-support

devoncarew avatar Mar 23 '23 21:03 devoncarew

Possibly something you can configure from the coveralls.io UI? https://coveralls.io/better-monorepo-support

I have no configuring powers on coveralls.io for this GitHub repo.

dcharkes avatar Mar 23 '23 22:03 dcharkes