David Ashpole

Results 568 comments of David Ashpole

My request is that if/when breaking changes to configuration or behavior take effect, users have an easy way to revert to the previous config or behavior for a period of...

We are fixing this behavior in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/24030

cc @fatsheep9146 It would be nice if the default behavior of otelhttp matched what you are doing in k8s so we don't need to implement our own naming function there.

Feel free to reopen if you have further qustions

That is correct. See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#metric-metadata-1 for unit guidance.

That is considered unitless in prometheus, so we should drop units (at the portion within the brackets) with `{}`. I'll update the spec to more fully describe the mapping.

@brandur That all sounds reasonable. Given the state of the project, we have to be careful not to break existing users, but lazily starting the goroutine should be backwards-compatible. Let...

/assign @dgrisonnet /triage accepted

You will also need to update your prometheus dependency to match what opencensus uses, as prometheus moved some packages around. `go get github.com/prometheus/[email protected]`