opentelemetry-collector-contrib [receiver/prometheus] Validate that the largest prometheus bucket is the +Inf bucket

Description:

This is just a small additional piece of validation to make sure our interpretation of Prometheus histograms is correct. Otherwise, our resulting histogram will place points that are in another bucket into the Inf bucket.

Testing:

Fixed some unit tests that were doing this.

Apr 20 '22 20:04 dashpole

cc @open-telemetry/wg-prometheus

Apr 25 '22 12:04 dashpole

Is there a test that checks the new scenario?

Apr 28 '22 15:04 TylerHelmuth

Is there a test that checks the new scenario?

I've restored the existing unit test without an inf bucket.

May 03 '22 18:05 dashpole

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Jun 13 '22 05:06 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Jul 06 '22 05:07 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Sep 27 '22 05:09 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Oct 12 '22 05:10 github-actions[bot]

Please rebase? Changes look good to me, tag me to review and approve afterwards.

Feb 12 '23 08:02 atoulme

@atoulme done

Feb 13 '23 14:02 dashpole

Foresight Summary

Major Impacts

build-and-test-windows duration(7 seconds) has decreased 43 minutes 29 seconds compared to main branch avg(43 minutes 36 seconds).

View More Details

:o: build-and-test-windows workflow has finished in 7 seconds (43 minutes 29 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

Job	Failed Steps	Tests
windows-unittest-matrix	- :link:	N/A	See Details
windows-unittest	- :link:	N/A	See Details

:white_check_mark: check-links workflow has finished in 43 seconds (1 minute 56 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

Job	Failed Steps	Tests
changed files	- :link:	N/A	See Details
check-links	- :link:	N/A	See Details

:white_check_mark: telemetrygen workflow has finished in 1 minute 20 seconds (1 minute 58 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

Job	Failed Steps	Tests
publish-latest	- :link:	N/A	See Details
build-dev	- :link:	N/A	See Details
publish-stable	- :link:	N/A	See Details

:white_check_mark: changelog workflow has finished in 2 minutes 22 seconds and finished at 28th Feb, 2023.

Job	Failed Steps	Tests
changelog	- :link:	N/A	See Details

:white_check_mark: build-and-test workflow has finished in 36 minutes 35 seconds (37 minutes 14 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

Job	Failed Steps	Tests
unittest-matrix (1.19, internal)	- :link:	✅ 561 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.20, internal)	- :link:	✅ 561 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.19, extension)	- :link:	✅ 537 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.19, processor)	- :link:	✅ 1525 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.20, processor)	- :link:	✅ 1525 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.20, extension)	- :link:	✅ 537 ❌ 0 ⏭ 0 :link:	See Details
correctness-traces	- :link:	✅ 17 ❌ 0 ⏭ 0 :link:	See Details
correctness-metrics	- :link:	✅ 2 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.20, receiver-0)	- :link:	✅ 2580 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.19, receiver-0)	- :link:	✅ 2580 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.20, exporter)	- :link:	✅ 2456 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.19, exporter)	- :link:	✅ 2456 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.19, receiver-1)	- :link:	✅ 1937 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.20, receiver-1)	- :link:	✅ 1937 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.20, other)	- :link:	✅ 4776 ❌ 0 ⏭ 0 :link:	See Details
unittest-matrix (1.19, other)	- :link:	✅ 4776 ❌ 0 ⏭ 0 :link:	See Details
integration-tests	- :link:	✅ 55 ❌ 0 ⏭ 0 :link:	See Details
setup-environment	- :link:	N/A	See Details
check-codeowners	- :link:	N/A	See Details
lint-matrix (receiver-0)	- :link:	N/A	See Details
lint-matrix (receiver-1)	- :link:	N/A	See Details
lint-matrix (processor)	- :link:	N/A	See Details
lint-matrix (exporter)	- :link:	N/A	See Details
lint-matrix (extension)	- :link:	N/A	See Details
lint-matrix (internal)	- :link:	N/A	See Details
lint-matrix (other)	- :link:	N/A	See Details
check-collector-module-version	- :link:	N/A	See Details
checks	- :link:	N/A	See Details
build-examples	- :link:	N/A	See Details
lint	- :link:	N/A	See Details
unittest (1.20)	- :link:	N/A	See Details
unittest (1.19)	- :link:	N/A	See Details
cross-compile (darwin, amd64)	- :link:	N/A	See Details
cross-compile (darwin, arm64)	- :link:	N/A	See Details
cross-compile (linux, 386)	- :link:	N/A	See Details
cross-compile (linux, amd64)	- :link:	N/A	See Details
cross-compile (linux, arm)	- :link:	N/A	See Details
cross-compile (linux, arm64)	- :link:	N/A	See Details
cross-compile (windows, 386)	- :link:	N/A	See Details
cross-compile (linux, ppc64le)	- :link:	N/A	See Details
cross-compile (windows, amd64)	- :link:	N/A	See Details
build-package (deb)	- :link:	N/A	See Details
build-package (rpm)	- :link:	N/A	See Details
windows-msi	- :link:	N/A	See Details
publish-check	- :link:	N/A	See Details
publish-stable	- :link:	N/A	See Details
publish-dev	- :link:	N/A	See Details

:white_check_mark: prometheus-compliance-tests workflow has finished in 3 minutes 24 seconds (6 minutes 4 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

Job	Failed Steps	Tests
prometheus-compliance-tests	- :link:	✅ 21 ❌ 0 ⏭ 0 :link:	See Details

:white_check_mark: load-tests workflow has finished in 7 minutes 17 seconds (10 minutes 52 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

Job	Failed Steps	Tests
loadtest (TestIdleMode)	- :link:	✅ 1 ❌ 0 ⏭ 0 :link:	See Details
loadtest (TestTraceAttributesProcessor)	- :link:	✅ 3 ❌ 0 ⏭ 0 :link:	See Details
loadtest (TestMetricResourceProcessor\|TestTrace10kSPS)	- :link:	✅ 12 ❌ 0 ⏭ 0 :link:	See Details
loadtest (TestTraceNoBackend10kSPS\|TestTrace1kSPSWithAttrs)	- :link:	✅ 8 ❌ 0 ⏭ 0 :link:	See Details
loadtest (TestMetric10kDPS\|TestMetricsFromFile)	- :link:	✅ 6 ❌ 0 ⏭ 0 :link:	See Details
loadtest (TestTraceBallast1kSPSWithAttrs\|TestTraceBallast1kSPSAddAttrs)	- :link:	✅ 10 ❌ 0 ⏭ 0 :link:	See Details
loadtest (TestBallastMemory\|TestLog10kDPS)	- :link:	✅ 18 ❌ 0 ⏭ 0 :link:	See Details
setup-environment	- :link:	N/A	See Details

:white_check_mark: e2e-tests workflow has finished in 13 minutes 14 seconds (3 minutes 36 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

Job	Failed Steps	Tests
kubernetes-test (v1.26.0)	- :link:	N/A	See Details
kubernetes-test (v1.25.3)	- :link:	N/A	See Details
kubernetes-test (v1.24.7)	- :link:	N/A	See Details
kubernetes-test (v1.23.13)	- :link:	N/A	See Details

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

Feb 13 '23 14:02 runforesight[bot]

opentelemetry-collector-contrib
opentelemetry-collector-contrib copied to clipboard

[receiver/prometheus] Validate that the largest prometheus bucket is the +Inf bucket

Foresight Summary

`build-and-test-windows` duration(7 seconds) has decreased 43 minutes 29 seconds compared to main branch avg(43 minutes 36 seconds).

:o: build-and-test-windows workflow has finished in 7 seconds (43 minutes 29 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: check-links workflow has finished in 43 seconds (1 minute 56 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: telemetrygen workflow has finished in 1 minute 20 seconds (1 minute 58 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: changelog workflow has finished in 2 minutes 22 seconds and finished at 28th Feb, 2023.

:white_check_mark: build-and-test workflow has finished in 36 minutes 35 seconds (37 minutes 14 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: prometheus-compliance-tests workflow has finished in 3 minutes 24 seconds (6 minutes 4 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: load-tests workflow has finished in 7 minutes 17 seconds (10 minutes 52 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: e2e-tests workflow has finished in 13 minutes 14 seconds (3 minutes 36 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

opentelemetry-collector-contrib opentelemetry-collector-contrib copied to clipboard

[receiver/prometheus] Validate that the largest prometheus bucket is the +Inf bucket

Foresight Summary

build-and-test-windows duration(7 seconds) has decreased 43 minutes 29 seconds compared to main branch avg(43 minutes 36 seconds).

:o: build-and-test-windows workflow has finished in 7 seconds (43 minutes 29 seconds less than main branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: check-links workflow has finished in 43 seconds (1 minute 56 seconds less than main branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: telemetrygen workflow has finished in 1 minute 20 seconds (1 minute 58 seconds less than main branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: changelog workflow has finished in 2 minutes 22 seconds and finished at 28th Feb, 2023.

:white_check_mark: build-and-test workflow has finished in 36 minutes 35 seconds (37 minutes 14 seconds less than main branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: prometheus-compliance-tests workflow has finished in 3 minutes 24 seconds (6 minutes 4 seconds less than main branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: load-tests workflow has finished in 7 minutes 17 seconds (10 minutes 52 seconds less than main branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: e2e-tests workflow has finished in 13 minutes 14 seconds (3 minutes 36 seconds less than main branch avg.) and finished at 28th Feb, 2023.

opentelemetry-collector-contrib
opentelemetry-collector-contrib copied to clipboard

`build-and-test-windows` duration(7 seconds) has decreased 43 minutes 29 seconds compared to main branch avg(43 minutes 36 seconds).

:o: build-and-test-windows workflow has finished in 7 seconds (43 minutes 29 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: check-links workflow has finished in 43 seconds (1 minute 56 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: telemetrygen workflow has finished in 1 minute 20 seconds (1 minute 58 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: build-and-test workflow has finished in 36 minutes 35 seconds (37 minutes 14 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: prometheus-compliance-tests workflow has finished in 3 minutes 24 seconds (6 minutes 4 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: load-tests workflow has finished in 7 minutes 17 seconds (10 minutes 52 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.

:white_check_mark: e2e-tests workflow has finished in 13 minutes 14 seconds (3 minutes 36 seconds less than `main` branch avg.) and finished at 28th Feb, 2023.