David Ashpole comments

Results 568 comments of


                                            David Ashpole

Kubernetes Component Health SLIs

/assign @logicalhan

use hierarchical_memory_limit instead of limit_in_bytes with cgroup v1

It looks like it somehow includes a bunch of unrelated commits. I was on board with the original set of changes, but the PR contents has to be fixed first.

Enforce tag equivalence in `view.same()`

He @rubensf! Right now we are only accepting security fixes or critical bug fixes. Can you say more about the issue this fixes?

Enforce tag equivalence in `view.same()`

Thanks for your understanding. If others hit this issue we can reconsider it, but i'll close it for now. Hopefully your workaround will save them some time.

[WIP] kubelet: Improved performance of the cadvisor metric collection

/assign @ehashman @dgrisonnet

dynamic resource allocation

/assign (for review of added metrics)

add metrics for health checks (for later use in apiserver)

/lgtm

receiver/jaeger: translation of Jaeger agent tags are lost

This repository is now archived, and is succeeded by https://github.com/open-telemetry/opentelemetry-collector.

agent -> collector TLS does not seem to work

This repository is now archived, and is succeeded by https://github.com/open-telemetry/opentelemetry-collector.

Metric Type is lost when receiving data from Java OC-Agent exporter

This repository is now archived, and is succeeded by https://github.com/open-telemetry/opentelemetry-collector.