Danny Chan

Results 382 comments of Danny Chan

> Makes sense. Let me think about this and put up separate PRs. Sure, please update the description when you finished the change so the reviewer can get a briefing...

Thanks for the work, I have reviewed and applied a patch here: [7522.patch.zip](https://github.com/apache/hudi/files/15228302/7522.patch.zip) Please supplement the tests with your spare time.

Currently only internal `HFile` enables the sort of payloads within a file, for PARQUETs in the dataset table, the merge would break the sequence in anyway. Take https://github.com/apache/hudi/blob/6c6bddcef3ec383b08eb10f10ab0400f4edc41f4/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandleFactory.java#L54 for a...

> I notice that the azure CI results are now grouped by folders? and could we show an example to illustrate that cross module FT coverage is now factored in?...

By default the Flink hudi bundle does not include any Hive related jar in dependencies, you need you package the jar manually following this doc: https://hudi.apache.org/docs/syncing_metastore#flink-setup

> is there any jar available on mvn ? No, you need to compile it manually.

Thanks for the feedback, the reason that we do not include the hive into Flink Hudi bundle jar is because Flink classloader and jar conflicts is more complex, there is...