hudi
hudi copied to clipboard
[HUDI-7669] Move config classes and utils to proper places
Change Logs
This PR moves config classes and utils to the proper places:
- Moves
ConfigProperty,EnumDescription,EnumFieldDescription,HoodieConfig,TypedPropertiesfromhudi-commontohudi-iomodule so that classes inhudi-ioandhudi-hadoop-commonmodules can use config-related logic. - Moves
DFSPropertiesConfigurationclass fromhudi-commontohudi-hadoop-commonmodule. - Moves
HoodieNotSupportedExceptionclass used by config utils fromhudi-commontohudi-iomodule. - Moves basic config utils from
ConfigUtilsinhudi-commonmodule toConfigUtilsinhudi-iomodule (tests are moved toTestConfigUtils). - Moves Hadoop-related config utils from
ConfigUtilstoHadoopConfigUtilsinhudi-hadoop-commonmodule (tests are moved toTestHadoopConfigUtils). - Moves Hudi-specific config utils from
ConfigUtilstoHoodieConfigUtilsinhudi-commonmodule.
Impact
Code refactoring for reuse and better organization.
Risk level
none
Documentation Update
none
Contributor's checklist
- [ ] Read through contributor's guide
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
Moves ConfigProperty, EnumDescription, EnumFieldDescription, HoodieConfig, TypedProperties from hudi-common to hudi-io module so that classes in hudi-io and hudi-hadoop-common modules can use config-related logic
It may solves the dependency issue, but from the first sight, these classes does not belong to hudi-io IMO, should we have a separate hudi-config module or hudi-api module (that we can put all the code API or interfaces in hudi core).
CI report:
- 105d20c9eb7387a89552061f32cb346dfdab2bc7 Azure: SUCCESS
Bot commands
@hudi-bot supports the following commands:@hudi-bot run azurere-run the last Azure build
Moves ConfigProperty, EnumDescription, EnumFieldDescription, HoodieConfig, TypedProperties from hudi-common to hudi-io module so that classes in hudi-io and hudi-hadoop-common modules can use config-related logic
It may solves the dependency issue, but from the first sight, these classes does not belong to
hudi-ioIMO, should we have a separatehudi-configmodule orhudi-apimodule (that we can put all the code API or interfaces in hudi core).
Makes sense. Let me think about this and put up separate PRs.
Makes sense. Let me think about this and put up separate PRs.
Sure, please update the description when you finished the change so the reviewer can get a briefing of the changes.
Closing this PR as it is no longer required.