Danny Chan

Results 335 comments of Danny Chan
trafficstars

@jinxing64 >SqlValidator infers the "type" of SqlDynamicParam by the "type" of CAST. And during the optimization, such a CAST will be regarded as redundant and get simplified/peeled. `SqlValidatorImpl` did use...

@yuqi1129 The best way i can think of is to merge in the expressions of `CAST` operator, because we know the physicalType and logicalType, we may need to know what...

-1, I think it's not a good idea to make so muck changes just to move constant reduction logic into RexImplicationChecker, because there is a rule/rules can do this. Actually...

> @XuQianJin-Stars @danny0405 > Issue says the TEXT can be considered a user defined type and that we shouldn't modify the parser. so then my PR is not suitable, maybe...

> @danny0405 sorry, I not find through add a sql dialect data type or make it pluggable and have a clear interface. Can you give me some suggestions? thanks. I'm...

Quotes Julian's comment in the mailing list: > Is there a change we could make to the rule API that would make it easier to customize rules? I have been...

@amaliujia Do you think this should be in the 1.26.0 ? And do you have time to review it ?

The digest is overridden by every data type, so what type you mean do not have the `field` info ? If the digest is not complete, we can just fix...

If it is ready for reviewing, you can ping someone for help :)