Danielle Foré

Results 943 comments of Danielle Foré
trafficstars

Looks like Chrome and Edge are also using "Ctrl Shift K". Safari uses Super Shift K. So it makes sense for us to be in line with what appears to...

Yeah I'm personally of the opinion that we should phase out the plug-in system completely. We don't currently have any system for distributing third party plugins like you said, and...

@jeremypw There's not really a reason why this "Open in" item is special and different from other "Open in" actions like new tab, new window, etc. If you need the...

@jeremypw sorry for taking a while to follow up on this! I pushed a commit with the filter icon we're using in Mail and fixing the sidebar background styles. I...

It doesn't look like "document-open-folder" is a valid icon name in the freedesktop specification, but I agree that it would make more sense than the icon name we're using now....

I'm not sure if this really solves the issue since in most cases we just end up with another single toplevel item. Perhaps we should revisit this after/as part of...

@jeremypw I don't really understand why this branch contains any changes to breadcrumbs at all? That seems unrelated to using a Popover instead of a Window here?

@jeremypw ah this is a +/-0 diff now :sweat_smile: That doesn't seem right

@jeremypw yeah I was thinking of starting yet another branch with just those changes that don't make sense to try to make ahead of time. I'm not sure it's really...

@jeremypw sounds like a plan! Thanks for your effort here. I know it's a complicated port!