files
files copied to clipboard
elementary
Make compile
This based on gtk4 branch up to commit "First compilable lint-free version"(https://github.com/elementary/files/commit/be0ce20d8679315424f58b88dff93e225ddce861) rebased onmain` plus a few extra commits to make it compile again.
The changes should be near the minimum to make it compile without removing widgets but still affects a large amount of code unfortunately.
The PR builds and runs (as io.elementary.files) but very little works
@danirabbit Thanks for the review and suggestions! I have updated things accordingly and it still compiles and runs.
@danirabbit Is it worth maintaining this branch? Or would it be best to start again once all the possible Gtk4 prep has been done in the Gtk3 branch to reduce the porting diff? All the code that could be used for reference is already in the gtk4- branches I think. There are a lot of conflicts now. Is it still the intention to have a single Gtk4 port branch once all the prep is done? What diff is acceptable?
@jeremypw yeah I was thinking of starting yet another branch with just those changes that don't make sense to try to make ahead of time.
I'm not sure it's really possible to come up with a number, but at least it should be feasible to review each class file. If there's refactoring required or there's things we can do to prepare in separate branches (like using event controllers or not using run in dialogs or not subclassing widgets that are now final classes etc) then we should do those separately to try to avoid regressions and make sure we're not trying to merge a branch that it's not really reasonable to review each of the changes
@danirabbit I am concentrating on Gtk4 preparation branches at the moment - I wont be doing anymore Gtk4 branches until there isnt any more prep that can be done. If you have any suggestions as to what should (or should not) be done in Gtk4Prep PRs let me know. I guess the Gtk4 port branch can always be reviewed commit by commit provided not every commit has to compile.
@jeremypw sounds like a plan! Thanks for your effort here. I know it's a complicated port!
@danirabbit Sorry for an off-topic message but I cannot seem to log into ele.slack.com any more - it insists on using [email protected] which no longer exists.
@jeremypw it looks like since we're not on a Pro plan I can't change other people's email addresses, so I sent a new invite to your gmail address. Sorry!