files
files copied to clipboard
elementary
[Gtk4Prep] Searchresults: Use popover
Cannot grab devices in Gtk4 - no reason to use another window, significant simplification possible.
Based on #2402
This sometimes produces terminal spam Gdk-CRITICAL **: 16:08:44.010: gdk_pixbuf_get_from_surface: assertion 'surface != NULL' failed for no apparent reason and no apparent effect (coming from the draw() function of the breadcrumbs). Attempts to fix without changing current behaviour failed. Hopefully porting to Gtk4 will fix.
@danirabbit Not sure if this is worth doing in Gtk3 or just do it during the Gtk4 port.
@danirabbit The search also seems broken in main , at least on Wayland, I'll have another look at this. Using a Popover should be less problematic than a custom POPUP type window I should think, if it can be got working.
I think I have fixed the issues with the placeholder - it seems to work on OS7.1 and OS8 (Wayland and X).
@jeremypw I don't really understand why this branch contains any changes to breadcrumbs at all? That seems unrelated to using a Popover instead of a Window here?
