Daniel Jacobs

Results 150 comments of Daniel Jacobs

Note, the tsx files weren't being linted so it's entirely possible that when this gets rebased it ends up with lint failures.

Another good one would be https://github.com/ruffle-rs/ruffle/issues/3725

Maybe @Rob--W could help. I know that's the Firefox team but I know Rob has looked into the timing of Chromium feature freezes and browser version releases a lot recently...

See also https://github.com/wdzeng/edge-addon/issues/16#issuecomment-2707209359

Quick thought/question: Is it okay to send the https://api.addons.microsoftedge.microsoft.com/v1/products/${productId}/submissions request immediately after the https://api.addons.microsoftedge.microsoft.com/v1/products/${productId}/submissions/draft/package succeeds, or should we be waiting an extra X seconds after that?

Also note, this time testing with the attached files and a directory named mp4-1200 containing the files from https://github.com/danielhjacobs/danielhjacobs.github.io/tree/main/mp4-1200, I get this error when opening anastasia2017-teacher.swf with a Desktop app...

Replacing https://github.com/ruffle-rs/ruffle/pull/14655/files#diff-894b995744e59b9d8803f92eb6b185191b9018cd571feeaeb4a7c53dbd9a0bc5R1380-R1385 with this removes the panic: ```rs match context.video.decode_video_stream_frame( video_handle, encoded_frame, context.renderer, ) { Ok(bitmap) => { write.last_decoded_bitmap = Some(bitmap); } Err(e) => { tracing::error!( "Decoding video frame {}...

@ManikanthMSFT It happened on: - Mon, 03 Mar 2025 00:17:44 GMT (https://github.com/ruffle-rs/ruffle/actions/runs/13620614396/job/38069491150#step:20:31 - An error occurred while performing the operation) - Sun, 02 Mar 2025 00:17:29 GMT (https://github.com/ruffle-rs/ruffle/actions/runs/13610082139/job/38046079824#step:20:17 - 404...

See also https://github.com/microsoft/MicrosoftEdge-Extensions/issues/273#issuecomment-2667395147