Daniel Jacobs

Results 150 comments of Daniel Jacobs

Note: If that's the issue, the same will be true of `` and `` and ``

Nah, the error seems unrelated to that: https://github.com/ruffle-rs/ruffle/actions/runs/10424284257/job/28872786614?pr=17539#step:11:16287: `message: 'no such element: Unable to locate element: {"method":"tag name","selector":"ruffle-object"}` I also tried these commands locally: ```bash cd web/packages/selfhosted/test/ grep -rl ''...

Actually, my errors are as follows: ``` [chrome-headless-shell 127.0.6533.119 linux #0-40] AssertionError: expected { error: { …(5) } } to deeply equal [ 'test' ] [chrome-headless-shell 127.0.6533.119 linux #0-40] at...

Required commands: ```bash cd web/packages/selfhosted/test/ grep -rl '' | xargs sed -i 's//ruffle-object/g' grep -rl '' | xargs sed -i 's//ruffle-embed/g' grep -rl '' | xargs sed -i 's//ruffle-object/g' grep...

- [test/polyfill/classic_frames_injected/test.ts](https://github.com/ruffle-rs/ruffle/tree/master/web/packages/selfhosted/test/polyfill/classic_frames_injected) - [test/polyfill/classic_frames_provided/test.ts](https://github.com/ruffle-rs/ruffle/tree/master/web/packages/selfhosted/test/polyfill/classic_frames_provided) - [test/polyfill/iframes_injected/test.ts](https://github.com/ruffle-rs/ruffle/tree/master/web/packages/selfhosted/test/polyfill/iframes_injected) - [test/polyfill/iframes_provided/test.ts](https://github.com/ruffle-rs/ruffle/tree/master/web/packages/selfhosted/test/polyfill/iframes_provided) - [test/integration_tests/external_interface/test.ts](https://github.com/ruffle-rs/ruffle/tree/master/web/packages/selfhosted/test/integration_tests/external_interface) These are the failing files after those changes.

That's the blocker for 4 of the 5 tests I believe, yes. I tried working around it in a few ways but the workarounds seem to have their own bugs....

https://github.com/ruffle-rs/ruffle/pull/17539/commits/656a068392e651d6f6adca21fd7d2097b04aaac0 works around the webdriverio frame switching issue but it makes the code much more complicated. [test/integration_tests/external_interface/test.ts](https://github.com/ruffle-rs/ruffle/tree/master/web/packages/selfhosted/test/integration_tests/external_interface) is still failing.

Pushed fix for EI test just as proof of concept. Converted to draft. Ideally, https://github.com/webdriverio/webdriverio/issues/13218 and https://github.com/webdriverio/webdriverio/issues/13444 will be fixed, we'll drop the latest two commits, bump to the version...

I actually tried that locally earlier today. At the very least doing so and then checking out https://github.com/ruffle-rs/ruffle/pull/17539/commits/de5be7c42228844aa0aae4b20a926ff82dda019b didn't let the frame/iframe tests pass.

Note: This is now waiting on a fix for https://github.com/webdriverio/webdriverio/issues/13763