Daniel Compton
Daniel Compton
This is potentially interesting but needs some review to make sure there are no subtle gotchas.
Would it be good to add some tests exercising this change?
If you can write some tests for `parse-number` that fail under the old implementation, that would be great. > But for overall parsing I tried to come up with a...
Parsing dates with `Date.parse()` [isn't recommended](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/parse) by MDN (I know this wasn't really your suggestion, I was just mentioning it as an aside on parsing). > It is not recommended...
Hi @khmelevskii, what are the types of the dates that you are comparing? UtcDateTimes? You could perhaps cast them to midnight and compare them with an equality check as an...
Does this affect code size at all? I'm wondering if it's going to pull in all of the Closure locales or other unneeded code?
It does work, but I have to wait the poll time on average before the build starts. Several hosted CI environments can take a calllback from the repo to tell...
@kongeor, @trhura, I talked with @tobias about what to do here. Given the context around @nickzam creating the group in #1 even though Nick wasn't the "owner" of the code,...
Yep, they all track versions. Most of the Jackson repos seem to be grouped together by Renovate, but these two weren't. Presumably there is some Maven metadata which slightly differs...
> I'd rather not break any other wild code, so I prefer 2 or 3. I think 2 will leave the validation effectively unused by 99.99% of users, which defeats...