humanize icon indicating copy to clipboard operation
humanize copied to clipboard

Setup deps.edn build and deploy

Open kongeor opened this issue 3 years ago • 12 comments
trafficstars

Per our discussion:

  • switching to deps.edn
  • CI with github actions
  • adding clj-kondo linting
  • building and deploying with tools build

Addresses #24 and #26

kongeor avatar Aug 25 '22 19:08 kongeor

The way tools build is wired it will follow the versioning scheme of MAJOR.MINOR.COMMITS. With this library being stable enough, this will look something like 1.0.85 etc. I like this versioning scheme, but if you have a different preference, let me know so we can adjust the code accordingly.

I have also published a test version which is the 1.0.999-SNAPSHOT.

kongeor avatar Aug 25 '22 19:08 kongeor

I still need @trhura to add me to the Clojars group so that i can make a deployment.

hlship avatar Sep 05 '22 19:09 hlship

@hlship clojure-humanize project is maintained by @kongeor in Clojars. I don't see it under my projects to add you as a member.

See https://clojars.org/clojure-humanize

trhura avatar Sep 06 '22 02:09 trhura

Hm, I'm not an admin of this project. A user with the handle nickzam is.

kongeor avatar Sep 11 '22 15:09 kongeor

See #1

kongeor avatar Sep 11 '22 15:09 kongeor

I couldn't find the user nickzam so this puts the clojars permission issue in a weird state. I'm not sure what is optimal here. I would consider changing the group of the project to something someone of us has admin rights and then grant admin privs to the other 2 for redundancy. It's inconvenient but I can't think of something else. Please let me know what you think.

kongeor avatar Oct 22 '22 07:10 kongeor

@kongeor, @trhura, I talked with @tobias about what to do here.

Given the context around @nickzam creating the group in #1 even though Nick wasn't the "owner" of the code, we feel happy about converting @kongeor from a member of the group to being an admin. Then @kongeor will be able to manage the group members from there.

How does that sound?

danielcompton avatar Oct 25 '22 08:10 danielcompton

Sounds good to me.

trhura avatar Oct 25 '22 16:10 trhura

Hi guys, is there something I can help you with?

nickzam avatar Oct 25 '22 16:10 nickzam

@nickzam Please help add @kongeor @hlship to https://clojars.org/clojure-humanize project as admins.

trhura avatar Oct 25 '22 17:10 trhura

Done.

nickzam avatar Oct 25 '22 18:10 nickzam

Thank you all for helping with this.

@hlship I've tested a snapshot version and it looks all right. You can try it too, if you want to verify that everything works as expected, and then we can release it :)

kongeor avatar Oct 25 '22 18:10 kongeor

We're currently looking at moving this under the clj-commons umbrella; neither I nor @kongeor have the admin rights to do so. When you get a chance, could you add one of us?

hlship avatar Mar 14 '23 20:03 hlship