Daniel Compton

Results 358 comments of Daniel Compton
trafficstars

Top of ns doc is probably nicer.

Great! I assume you would want to keep the js/css dependencies small, i.e. no bootstrap?

Ah right, that makes sense, I'll do that instead. Thanks!

I tried that, and it didn't seem to work, the `h2/html` was re-escaping the `html5` document. ```clojure ;; requires: ;; [hiccup2.core :as h2] ;; [hiccup.core :as h] ;; [hiccup.page :refer...

Would you be able to add some tests for this change?

I just hit this (or a similar issue?) on a PUT route. I'm not sure exactly what is required for this, but Leiningen's headers that it sends when deploying are:...

This seems like a pretty sensible default, but it is a very breaking change. There are also some other new security related attributes that it could be nice to default...

Neat, thanks. Here's what I did for reference, or other searchers: ``` (extend-protocol MessageBody RawString (to-body [rs representation] (to-body (str rs) representation)) (content-length [rs] nil)) ``` > hiccup 2.x is...

This technically works, but everything is upside down, alignment is off, and it includes the ascii terminal codes. ```clj (defmethod yada.body/render-error "text/html" [status ^Throwable error representation {:keys [id options resource]...

This is not too bad: ```clj (defmethod yada.body/render-error "text/html" [status ^Throwable error representation {:keys [id options resource] :as ctx}] (html [:head [:title "Error"] [:style {:type "text/css"} (slurp (io/resource "style.css"))]] [:body...