David Pilato

Results 329 comments of David Pilato

Ha! Indeed. I misread the PR. You actually reverted the change to 7.15. So all good on my end. Thansk for moving forward this PR ;)

So I guess I can close this one. Thanks!

Hey I'm getting the same issue when building a multiarch on macOS. The same exact code with 0.43.2 is passing. Upgrading to 0.43.4 is failing. I'm feeling that the error...

> I've released [0.44.0](https://repo1.maven.org/maven2/io/fabric8/docker-maven-plugin/0.44.0/) . I've tested it by building and pushing image to `ghcr.io` using buildx on Windows, MacOS (via GitHub action) and Linux. > > I think your...

Ha! Funny. I was working on it today. My plan is to do it by next week if possible.

I fixed the failing tests. I "just" need now to do some refactoring and add a configuration as we spoke in https://github.com/langchain4j/langchain4j/pull/712#issuecomment-2066643407 ;) Stay tuned.

Hey @langchain4j. I think this PR is now ready for review. I updated the original description. In the future, we would also like to add more flexibility for the field...

I just realized that I need actually to write some docs in https://github.com/langchain4j/langchain4j/blob/main/docs/docs/integrations/embedding-stores/elasticsearch.md

While working on the documentation, I realized that I will need to change in a follow up PR the code in - [ElasticsearchEmbeddingStoreExample](https://github.com/langchain4j/langchain4j-examples/blob/main/elasticsearch-example/src/main/java/ElasticsearchEmbeddingStoreExample.java)

@langchain4j I added also some documentation to make the Elasticsearch page a bit less "empty" ;)