David Pilato

Results 323 comments of David Pilato

Well. I'd need a pull request! 🤣 I mean: would you like to contribute such a thing? Note that I'm now producing a version per major elasticsearch version, 5.x, 6.x...

I think we need to create new modules under https://github.com/dadoonet/fscrawler/tree/master/distribution like `docker` or `docker-es7`, `docker-es6`, `docker-es5` and follow the example described at https://github.com/moditect/moditect/wiki/Creating-dependency-images#example-a-dependency-image-for-vertx I have no experience on this 😄

> The main docker file in this repository is for fscrawler only, and not for elasticsearch. Yeah. FSCrawler es 5,6,7 actually does not embed any elasticsearch instance. It just describes...

I realize I should have only linked to http://dmp.fabric8.io/ and specifically http://dmp.fabric8.io/#docker:build and http://dmp.fabric8.io/#docker:source

Note that current master branch supports `/var/log/logstash/logstash-plain.log`.

I think we need to implement this #805

Could you please rebase your code on master? It will most likely remove the first commit as I merged it today and should make Travis-CI happy with your change so...

In your commit message, could you also add: ``` Closes #846 ``` So when merged, this will close automatically the initial issue.

Could you rebase your branch on master and solve the conflicts?

I don't think it's a rebase. Did you really rebase on master?