David Pilato

Not on my side sadly. Wanna work on it?

Hey @Thurdi Sorry for the delay. Would you like to create a proper branch for this in your fork and then send a draft PR so we can more easily...

Do you have a service already using this 8080 address running?

I gave a quick look at #610 and that looks ok to me. The biggest conflict I'll have to resolve will be about IT with the new cloud tests. But...

I updated my branch so it's up to date with the main branch. But note that I modified the Java version to 9. I can change that but I'd not...

I have a question about the design. The current state of the PR introduces a new class named `ElasticsearchKnnEmbeddingStore`. With the same "semantic" as the `ElasticsearchEmbeddingStore` class. So it's a...

I spoke with @swallez and he proposed another alternative which is the best world of the 2: ```java ElasticsearchEmbeddingStore.builder() .restClient(restClient) .indexName(indexName) .config(XXX) .build(); ``` Where `XXX` is a configuration class....

When #610 has been added, it assumed some scores in tests when doing filtering. The problem I have yet with the Elasticsearch Knn implementation is that Elasticsearch is adding the...

So I moved the filters within the knn query (as pre filters) and I hope that they won't affect the score anymore. But I need https://github.com/elastic/elasticsearch-java/issues/774 to be fixed first...

And I think that for the integration tests, we should either rely on the rank of each document but not on the score, or may be have a way for...