Alex Boten

Results 309 comments of Alex Boten
trafficstars

Updated the description to link to the dotnet PR and issue, thanks @pellared for the link!

This was discussed at the 22-Jul-2024 working group meeting and there were no objections, one question did come up around whether this release would be useful without the spec change...

That makes sense to me

Creating the v0.3.0 release now

> I take it there is a Pro plan that could be used Right, we use the pro version for the collector releases. I don't have a strong preference other...

I like the idea of generating 1 if no `service.instance.id` is present.

Mainly what I'm looking for feedback on is https://github.com/open-telemetry/opentelemetry-collector/pull/10912/files#diff-8992ea9c665081035bd866a386bc9510ee77af8cbb7137182e0fbcf38b92d64a and the changes in service.go The generated code needs some more fixing. Pinging @mx-psi as this is following the proposed approach...

> We give up on being able to have different metrics on the same 3rd party library being spread across different levels, but I think that's okay (we are not...

After spending a long time discussing various options, I think the best way to move forward is to replace `MeterProvider` with `LeveledMeterProvider`, and keep `MetricsLevel`. Adding `LeveledMeterProvider` gives slightly better...

> Do you have a link for those? I am guessing these need to be recorded by sync instruments, right? Right in both cases they're synchronous instruments. I thought of...