Christoph John

Results 224 comments of Christoph John

Hi @MuhammadhAadhil thanks for the PR. In the meantime there was a request which is quite similar #402. See my comment there: https://github.com/quickfix-j/quickfixj/issues/402#issuecomment-877085372 The question is: do you want to...

Hi @MuhammadhAadhil , do you wanted to consider the points from https://github.com/quickfix-j/quickfixj/pull/624#issuecomment-1498860723 ?

Could you please clarify a little? Could you supply a small test case that shows what you want to achieve? Moreover, your description says `ValidateUnorderedGroupFields` but the title says `ValidateFieldsOutOfOrder`....

IIRC each repeating group (regardless if nested or not) will be parsed using the dictionary. Maybe I'll find time to create a unit test, or maybe you could do that?...

Hi @MarcosVillacanas , thanks for the PR 👍 However, I personally cannot validate if this change is OK (also see #596) so it will probably take some time unless someone...

Hi @mgatny , thanks for the PR. Sounds like a sensible enhancement. At first sight, without digging deeper into the code, the following approach might also work: Set `RejectMessageOnUnhandledException=Y` and...

As you noted on https://github.com/quickfix-j/quickfixj/issues/621#issuecomment-1572077072 probably it would be a good thing to have a config option to restrict the maximum number of messages that could be resent. The beginning...

I've added `RejectMessageOnUnhandledException` a couple of years ago since there sometimes were unhandled exceptions, the seqnum was not incremented and one was in an endless loop because the same problematic...

Hi @mgatny is `RejectMessageOnUnhandledException` good enough for your use case? Thanks, Chris

@wajncn actually there was already a PR created by @philipwhiuk which should solve this: #643 Does this also work for you?