quickfixj icon indicating copy to clipboard operation
quickfixj copied to clipboard

Allow number of retries on failover

Open MuhammadhAadhil opened this issue 2 years ago • 5 comments
trafficstars

Fixes #250 Enhancement.

MuhammadhAadhil avatar Mar 24 '23 20:03 MuhammadhAadhil

Hi @MuhammadhAadhil

thanks for the PR. In the meantime there was a request which is quite similar #402. See my comment there: https://github.com/quickfix-j/quickfixj/issues/402#issuecomment-877085372

The question is: do you want to give it a try to introduce some kind of interface which enables users to customize the failover behaviour? The default behaviour could still have your changes with the number of retries (so we would have an improvement to the status quo).

Cheers Chris

chrjohn avatar Apr 06 '23 10:04 chrjohn

Hi @chrjohn ,

It is an interesting change. Let me see on this and keep you posted.

MuhammadhAadhil avatar Apr 07 '23 05:04 MuhammadhAadhil

Hi @chrjohn , May i know when this change will be added to the release. If there any more actions needed from my side, please be kind enough to guide me since this is my first change.

MuhammadhAadhil avatar Aug 09 '23 05:08 MuhammadhAadhil

Hi @MuhammadhAadhil , do you wanted to consider the points from https://github.com/quickfix-j/quickfixj/pull/624#issuecomment-1498860723 ?

chrjohn avatar Aug 17 '23 10:08 chrjohn

Hi @chrjohn , Actually i'm not in a position to work on that enhancement at the moment. This year being a little hard on my career. Lets give the feature with next release. We can enhance in future.#624

MuhammadhAadhil avatar Aug 17 '23 11:08 MuhammadhAadhil