Christopher Radek

Results 27 comments of Christopher Radek
trafficstars

@martymcflyDMC Thanks for opening this issue. The integrations from `analytics.js-integrations` don't conform to the [Plugin](https://github.com/segmentio/analytics-next/blob/86ed4948916d2f37bfc037c32491f437ce47cd7f/src/core/plugin/index.ts#L14) interface. Both the `Plugin` interface and the integrations have a `load` method, but they accept...

@martymcflyDMC Are you trying to use some integrations without setting them up as part of your Segment source, or are you developing your own integration?

Note: I believe some tests are sometimes timing out because validation errors are getting retried. I believe validation errors should fail without retries since the data being validated doesn't change...

@yordis Definitely interested in the topic of bundle sizes. The thing we need to be very careful with changes like these are making sure we stay backwards-compatible with the version...

@KeKs0r Thanks for creating this issue! Can you update the code to include a catch handler like this? ```ts export const analytics = SEGMENT_TOKEN ? await AnalyticsBrowser.load({ writeKey: SEGMENT_TOKEN }).catch(()...

Merging into a feature branch to trigger ci, then will merge into master!

@bartes This has now been merged into master via #700 We're currently in the middle of deploying updates so this change will be deployed either later this week or early...

>2. Not exactly sure what you're getting at here The context keeps logs/stats about which plugins were ran. Currently you can see which actions are ran and some stats about...

@dcow Thanks for reporting this. I actually just ran into this issue myself so the timing is perfect - will have a PR to fix this shortly!

The `calculateMaxTotalRetryTime` calculation makes sense - it's the sum of the maximum backoff amounts given an allowed number of attempts. I think this leads to a lower expiration than expected...