analytics.js-integrations
analytics.js-integrations copied to clipboard
segmentio
upgrade castle integration
What does this PR do?
- switched castle integration to the new castle script (https://www.npmjs.com/package/@castleio/castle-js). old one (https://www.npmjs.com/package/castle.js) is no longer maintained. Maps segment.page to https://docs.castle.io/docs/sdk-browser#castlepage and segment.track to https://docs.castle.io/docs/sdk-browser#castlecustom .
Are there breaking changes in this PR?
- no , legacy integrations should work without any changes
Testing Testing completed successfully using unit test, and by updating 2 integrations with the dev:build
- test suite has been updated and extended accordingly
Any background context you want to provide?
- this PR switches setup to the new script which includes additional features
Is there parity with the server-side/android/iOS integration components (if applicable)?
- not yet
Does this require a new integration setting? If so, please explain how the new setting works
- no (but some legacy options are no longer needed, and were removed)
Links to helpful docs and other external resources
- https://docs.castle.io/docs/sdk-browser
Commenting so that I'll be notified when this PR is merged (so that I can merge the associated docs PR!)
@bartes Thanks for opening this PR and sorry for the delay in getting someone to review it.
Overall this looks great. The HISTORY.md needs a minor update and the PR needs a merge from the master branch due to some conflicts but otherwise I don't see any issues with these changes!
Great, thanks for the review. The requested updates have been applied.
Hi @chrisradek . Not sure what is the merging process looks like. Do you think we could have this merged this week ?
Merging into a feature branch to trigger ci, then will merge into master!
@bartes This has now been merged into master via #700
We're currently in the middle of deploying updates so this change will be deployed either later this week or early next week.