Chris Krycho

Results 769 comments of Chris Krycho

@simonihmig can you add the ember-cli-typescript version to the writeup there when you get a chance, please?

At first blush this definitely looks like a bug in the intersection of Babel's TS plugin and its class fields plugin… and it *doesn't* happen if decorators are present? Quite...

See also previous discussion around *our* notion of semver etc. in #190. We mostly didn't cover types there, just TS itself and Ember and our own stability aims, but it's...

100% in favor of the “write a crazy number of tests” plan and 👍🏼 on all of this more generally. Thanks for taking this on!

@mike-north what's the status on this one? I don't recall seeing the typever stuff land here at all, and if so that's obviously fine; we've all been super busy 😂...

Have you tried the branch in #223?

@lupestro can you see whether this is still an issue in 1.5, and also whether it's an issue in the v2 beta?

This *used* to be a limitation of our type definitions, but it *should* have been fixed when we resolved #226 via definitelytyped/definitelytyped#28282. @mike-north or @dwickern do you have any idea...

In the typings we've written, we've made a point to capture what the types *actually are*, and so long as Ember is using RSVP, we want the types to model...