Chris Krycho

Results 750 comments of Chris Krycho
trafficstars

@danielrosenwasser just raising this for your info; I'm going to try to have a minimal repro of some sort next week filed as a bug on the TS repo on...

Trying to spend a bit of time digging into this today. Will report what I find!

@DanielRosenwasser will do! Anything else I should look for in terms of isolating where it's coming from?

That would explain some of the difficulty I've been having rebuilding an example that explodes. It also maps with my observation that imports seem to be relevant, likely because of...

@DanielRosenwasser I've pushed a repo with a repro-of-sorts [here](https://github.com/chriskrycho/ts-repro). I'm happy to open an issue, but I'm actually not exactly sure *how* to capture this at this point: - there's...

@tschoartschi there's a Known Issues section in the docs, and I'd happily take a PR noting this is an issue on TS versions 3.1–3.3 there. We also plan to address...

Elaboration: this happens when you write a decorated task like this: ```ts import Component from '@ember/component'; import { action } from '@ember-decorators/object'; import { task } from 'ember-concurrency-decorators'; export default...

Thanks so much for writing this up! We'll try to get it integrated into the docs sometime this week!

This has since been fixed: it [now takes `Enumerable`][current], which correctly accepts native arrays as well. [current]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/d31733647c3751adda12e0c260985734d809a6cb/types/ember__array/mutable.d.ts#L41

Ah, you are correct, my apologies! (Thanks for reopening, @mike-north!)