Chris Krycho

Results 721 comments of Chris Krycho
trafficstars

Still on my radar and I’ll likely get to it in the second week of August. (July had a few things I wasn’t expecting work-wise!)

Thanks for opening this! If you like, one of us will be happy to mentor you through getting the change into DefinitelyTyped!

Sorry for the delay, and thanks for reporting this. There's a tricky issue here, in that `createRecord` will happily accept items which are _not_ part of the schema. If I...

Yeah, I was thinking about that later as well. Maybe the right thing to do is default to constraining this the same way we do the others, but providing a...

@Krzyrok so sorry you're running into this! If possible, reproductions of this issue would help us chase it down. If you can provide an addon which does, and an addon...

I think there's an important distinction here around our use of CI tooling: between *failure* and a *warning* about upcoming changes that will affect us. That includes, as I note...

> Personally, I want to see these failures. Particularly once the e-cli beta starts passing again, I definitely want it to be obvious if we're considering a merge that would...

@dwickern or @mike-north do you have any idea what's going on here? It's obviously an upstream issue in TS, but I'm also curious if we can at least identify *why*...

On my to-do list for most likely next week to get a solid repro so I can help the TS team chase down the root of this regression.

That tracks with my own observation around where the regression happened in TS 3.1: it seems to be a regression when combining mapped types and conditional types.